Commit b5271f2
Eric Bower
·
2026-02-26 09:41:57 -0500 EST
parent cc9a108
fix(pssh): race in tests
1 files changed,
+10,
-4
+10,
-4
| ... | ... | @@ -105,8 +105,11 @@ func TestSshServerSftp(t *testing.T) { | |
| 105 | 105 | // Wait for listener to be created | |
| 106 | 106 | var actualAddr string | |
| 107 | 107 | for i := 0; i < 100; i++ { | |
| 108 | - | if server.Listener != nil { | |
| 109 | - | actualAddr = server.Listener.Addr().String() | |
| 108 | + | server.Mu.Lock() | |
| 109 | + | listener := server.Listener | |
| 110 | + | server.Mu.Unlock() | |
| 111 | + | if listener != nil { | |
| 112 | + | actualAddr = listener.Addr().String() | |
| 110 | 113 | break | |
| 111 | 114 | } | |
| 112 | 115 | time.Sleep(10 * time.Millisecond) |
| ... | ... | @@ -205,8 +208,11 @@ func TestSshServerRsync(t *testing.T) { | |
| 205 | 208 | // Wait for listener to be created | |
| 206 | 209 | var actualAddr string | |
| 207 | 210 | for i := 0; i < 100; i++ { | |
| 208 | - | if server.Listener != nil { | |
| 209 | - | actualAddr = server.Listener.Addr().String() | |
| 211 | + | server.Mu.Lock() | |
| 212 | + | listener := server.Listener | |
| 213 | + | server.Mu.Unlock() | |
| 214 | + | if listener != nil { | |
| 215 | + | actualAddr = listener.Addr().String() | |
| 210 | 216 | break | |
| 211 | 217 | } | |
| 212 | 218 | time.Sleep(10 * time.Millisecond) |